gpio/vt8500: Convert to devm_ioremap_resource()
authorSachin Kamat <sachin.kamat@linaro.org>
Mon, 4 Mar 2013 09:09:39 +0000 (14:39 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 27 Mar 2013 15:05:10 +0000 (16:05 +0100)
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-vt8500.c

index 81683ca..b2d8d6f 100644 (file)
@@ -309,11 +309,9 @@ static int vt8500_gpio_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       gpio_base = devm_request_and_ioremap(&pdev->dev, res);
-       if (!gpio_base) {
-               dev_err(&pdev->dev, "Unable to map GPIO registers\n");
-               return -ENOMEM;
-       }
+       gpio_base = devm_ioremap_resource(&pdev->dev, res);
+       if (IS_ERR(gpio_base))
+               return PTR_ERR(gpio_base);
 
        ret = vt8500_add_chips(pdev, gpio_base, of_id->data);