Use errnoToString instead of strerror

Change-Id: I244e70b9f6dbcbc580b071c408c3531f8c0ffa22
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>

diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt
index d9968998496b5d8fdbad41671f966a784e7ad7cf..ae76ae718c951626c1539dc4b23ce4ff3cff7bf4 100644 (file)
--- a/src/common/CMakeLists.txt
+++ b/src/common/CMakeLists.txt
@@ -1,7 +1,7 @@
 PKG_CHECK_MODULES(COMMON_DEP
+    REQUIRED
     dlog
     libsmack
-    REQUIRED
     )
 
 SET(COMMON_SOURCES
@@ -27,7 +27,7 @@ SET(COMMON_SOURCES
 SET_SOURCE_FILES_PROPERTIES(
     ${COMMON_SOURCES}
     PROPERTIES
-        COMPILE_FLAGS "-fvisibility=default"
+        COMPILE_FLAGS "-D_GNU_SOURCE -fPIC -fvisibility=default" #TODO: visibility hidden
     )
 
 INCLUDE_DIRECTORIES(SYSTEM
@@ -47,8 +47,7 @@ ADD_LIBRARY(${TARGET_COMMON} SHARED ${COMMON_SOURCES})
 SET_TARGET_PROPERTIES(
     ${TARGET_COMMON}
     PROPERTIES
-        COMPILE_FLAGS "-D_GNU_SOURCE -fPIC"
-        SOVERSION 1.0.0
+        SOVERSION 1.0.0 #TODO: version tracking by rpm spec version specification
         VERSION 1.0.0
     )
 

diff --git a/src/common/include/error-description.h b/src/common/include/error-description.h
index f4e761355be98c656444491017b5b06db3b17914..4338cb4c1c1e77afe3c6e6a3ae9c1aa98ea96e4d 100644 (file)
--- a/src/common/include/error-description.h
+++ b/src/common/include/error-description.h
@@ -22,10 +22,11 @@
 #define _AUTH_PASSWD_ERROR_DESCRIPTION_
 
 #include <string>
+#include <cerrno>
 
 namespace AuthPasswd {
 
-std::string errnoToString(int err);
+std::string errnoToString(int err = errno);
 
 } // namespace AuthPasswd
 

diff --git a/src/server/CMakeLists.txt b/src/server/CMakeLists.txt
index 2e29f659245a2c51ce30b1bc5bcb57f36aadb688..ef870b2724b8d08078d62c8f2b641c618a3bca1b 100644 (file)
--- a/src/server/CMakeLists.txt
+++ b/src/server/CMakeLists.txt
@@ -1,10 +1,10 @@
 PKG_CHECK_MODULES(SERVER_DEP
+    REQUIRED
     dlog
     openssl
     libsmack
     libsystemd-daemon
     libtzplatform-config
-    REQUIRED
     )
 FIND_PACKAGE(Threads REQUIRED)
 

diff --git a/src/server/service/password-file.cpp b/src/server/service/password-file.cpp
index 359f3c9670dc27af57c54cf7c489505e887c2323..62d8dde5de29917d029c36e724aca1189b58a40d 100644 (file)
--- a/src/server/service/password-file.cpp
+++ b/src/server/service/password-file.cpp
@@ -154,14 +154,14 @@ namespace AuthPasswd
 
         if (!dirExists(RW_DATA_DIR)) {
             if(mkdir(RW_DATA_DIR, 0700)) {
-                LogError("Failed to create directory for files. Error: " << strerror(errno));
+                LogError("Failed to create directory for files. Error: " << errnoToString());
                 Throw(PasswordException::MakeDirError);
             }
         }
 
         if (!dirExists(userDir.c_str())) {
             if(mkdir(userDir.c_str(), 0700)) {
-                LogError("Failed to create directory for files. Error: " << strerror(errno));
+                LogError("Failed to create directory for files. Error: " << errnoToString());
                 Throw(PasswordException::MakeDirError);
             }
         }
@@ -203,7 +203,7 @@ namespace AuthPasswd
                 // and remove old file
                 if (remove(oldVersionPwdFile.c_str())) {
                     LogError("Failed to remove file" << oldVersionPwdFile <<
-                             " Error: " << strerror(errno));
+                             " Error: " << errnoToString());
                     Throw(PasswordException::RemoveError);
                 }
                 return;
@@ -297,7 +297,7 @@ namespace AuthPasswd
         pwdBuffer.Save(pwdFile);
 
         if (chmod(pwdFile.c_str(), FILE_MODE)) {
-            LogError("Failed to chmod for " << pwdFile << " Error: " << strerror(errno));
+            LogError("Failed to chmod for " << pwdFile << " Error: " << errnoToString());
             Throw(PasswordException::ChmodError);
         }
     }

diff --git a/src/server/service/policy-file.cpp b/src/server/service/policy-file.cpp
index 3c96320fff234593d4f3a1a998dd73dc09454515..f06a7e880e3850725117e037a29752c232446a49 100644 (file)
--- a/src/server/service/policy-file.cpp
+++ b/src/server/service/policy-file.cpp
@@ -59,14 +59,14 @@ namespace AuthPasswd
 
         if (!dirExists(RW_DATA_DIR)) {
             if(mkdir(RW_DATA_DIR, 0700)) {
-                LogError("Failed to create directory for files. Error: " << strerror(errno));
+                LogError("Failed to create directory for files. Error: " << errnoToString());
                 Throw(PasswordException::MakeDirError);
             }
         }
 
         if (!dirExists(userDir.c_str())) {
             if(mkdir(userDir.c_str(), 0700)) {
-                LogError("Failed to create directory for files. Error: " << strerror(errno));
+                LogError("Failed to create directory for files. Error: " << errnoToString());
                 Throw(PasswordException::MakeDirError);
             }
         }
@@ -139,7 +139,7 @@ namespace AuthPasswd
         policyBuffer.Save(policyFile);
 
         if (chmod(policyFile.c_str(), FILE_MODE)) {
-            LogError("Failed to chmod for " << policyFile << " Error: " << strerror(errno));
+            LogError("Failed to chmod for " << policyFile << " Error: " << errnoToString());
             Throw(PasswordException::ChmodError);
         }
     }