From: Jihoon Kim <jihoon48.kim@samsung.com>

Subject: Re: [E-devel] [PATCH] Fix the bug that user cannot input key

At this moment, space is processed in case of WM_KEYDOWN and WM_CHAR.

Therefore, 'space' key is processed twice, it makes bug.

In previous my patch, I changed keyname and string wrong.

I send the revised patch again.

(also applied to wince)

this is am improvement.. but its not all "right" yet. :(

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/ecore@64597 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/lib/ecore_win32/ecore_win32.c b/src/lib/ecore_win32/ecore_win32.c
index aca3d78..1d21463 100644 (file)
--- a/src/lib/ecore_win32/ecore_win32.c
+++ b/src/lib/ecore_win32/ecore_win32.c
@@ -86,10 +86,10 @@ _ecore_win32_window_procedure(HWND   window,
        INF("keydown message");
        _ecore_win32_event_handle_key_press(data, 1);
        return 0;
-     /* case WM_CHAR: */
-     /*   INF("char message"); */
-     /*   _ecore_win32_event_handle_key_press(data, 0); */
-     /*   return 0; */
+     case WM_CHAR:
+       INF("char message");
+       _ecore_win32_event_handle_key_press(data, 0);
+       return 0;
      case WM_KEYUP:
        INF("keyup message");
        _ecore_win32_event_handle_key_release(data, 1);

diff --git a/src/lib/ecore_win32/ecore_win32_event.c b/src/lib/ecore_win32/ecore_win32_event.c
index 55bbcc6..3567a6b 100644 (file)
--- a/src/lib/ecore_win32/ecore_win32_event.c
+++ b/src/lib/ecore_win32/ecore_win32_event.c
@@ -798,11 +798,6 @@ _ecore_win32_event_keystroke_get(int    key,
            kc = "KP_Delete";
          }
        break;
-     case VK_SPACE:
-       kn = "space";
-       ks = "space";
-       kc = "space";
-       break;
      case VK_F1:
        kn = "F1";
        ks = "F1";
@@ -994,7 +989,7 @@ _ecore_win32_event_char_get(int    key,
      case VK_SPACE:
        strncpy(kn, "space", 32);
        strncpy(ks, "space", 32);
-       strncpy(kc, "space", 32);
+       strncpy(kc, " ", 32);
        break;
      default:
        /* displayable characters */

diff --git a/src/lib/ecore_wince/ecore_wince_event.c b/src/lib/ecore_wince/ecore_wince_event.c
index d5cda30..b7b177b 100644 (file)
--- a/src/lib/ecore_wince/ecore_wince_event.c
+++ b/src/lib/ecore_wince/ecore_wince_event.c
@@ -123,11 +123,6 @@ _ecore_wince_event_keystroke_get(int    key,
        ks = "Delete";
        kc = "Delete";
        break;
-     case VK_SPACE:
-       kn = "space";
-       ks = "space";
-       kc = "space";
-       break;
      case VK_F1:
        kn = "F1";
        ks = "F1";
@@ -337,7 +332,7 @@ _ecore_wince_event_char_get(int    key,
      case VK_SPACE:
        strncpy(kn, "space", 32);
        strncpy(ks, "space", 32);
-       strncpy(kc, "space", 32);
+       strncpy(kc, " ", 32);
        break;
      default:
        /* displayable characters */