e_iput_evdev: fix dead code 49/295649/1
authorJihoon Kim <jihoon48.kim@samsung.com>
Wed, 12 Jul 2023 05:57:41 +0000 (14:57 +0900)
committerTizen Window System <tizen.windowsystem@gmail.com>
Wed, 12 Jul 2023 06:39:40 +0000 (15:39 +0900)
dead_error_line (572 line):
Execution cannot reach the expression NULL inside this statement: (glist = (glist ? ((GList *....

Change-Id: I36c1397198be905a61021ee5b744a415a3148252
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
src/bin/e_comp_wl.c
src/bin/e_input_evdev.c

index 5102ebe..26ae16d 100644 (file)
@@ -6128,7 +6128,6 @@ e_comp_wl_cursor_hide(E_Client *ec)
    struct wl_resource *surface = e_comp_wl_client_surface_get(ec);
    EINA_SAFETY_ON_NULL_RETURN_VAL(surface, EINA_FALSE);
 
-   if (!surface) return EINA_FALSE;
    wc = wl_resource_get_client(surface);
    serial = wl_display_next_serial(e_comp_wl->wl.disp);
    EINA_LIST_FOREACH(e_comp_wl->ptr.resources, l, res)
index d8af470..c510e3f 100644 (file)
@@ -567,15 +567,17 @@ _device_handle_key(struct libinput_device *device, struct libinput_event_keyboar
    if (edev->e_dev) e_dev = edev->e_dev;
    else if (edev->e_dev_list && g_list_length(edev->e_dev_list) > 0)
      {
-        for (glist = edev->e_dev_list, e_dev_data = edev->e_dev_list->data;
-             glist; \
-             glist = g_list_next(glist), e_dev_data = G_LIST_GET_DATA(glist))
+        glist = edev->e_dev_list;
+        while (glist)
           {
+             e_dev_data = glist->data;
              if (e_device_class_get(e_dev_data) == ECORE_DEVICE_CLASS_KEYBOARD)
                {
                   e_dev = e_dev_data;
                   break;
                }
+
+             glist = g_list_next(glist);
           }
      }
    else