gpio: zynq: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 27 Aug 2020 20:08:27 +0000 (22:08 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 28 Aug 2020 18:16:06 +0000 (20:16 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-zynq.c

index 53d1387..0b5a17a 100644 (file)
@@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev)
 
        /* Retrieve GPIO clock */
        gpio->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(gpio->clk)) {
-               if (PTR_ERR(gpio->clk) != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "input clock not found.\n");
-               return PTR_ERR(gpio->clk);
-       }
+       if (IS_ERR(gpio->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");
+
        ret = clk_prepare_enable(gpio->clk);
        if (ret) {
                dev_err(&pdev->dev, "Unable to enable clock.\n");