net: Use kmemdup instead of kmalloc and memcpy
authorShyam Saini <mayhs11saini@gmail.com>
Fri, 23 Dec 2016 19:14:58 +0000 (00:44 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Dec 2016 16:37:14 +0000 (11:37 -0500)
when some other buffer is immediately copied into allocated region.
Replace calls to kmalloc followed by a memcpy with a direct
call to kmemdup.

Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c

index 4a10500..2cea022 100644 (file)
@@ -1236,10 +1236,9 @@ static int virtnet_set_mac_address(struct net_device *dev, void *p)
        struct sockaddr *addr;
        struct scatterlist sg;
 
-       addr = kmalloc(sizeof(*addr), GFP_KERNEL);
+       addr = kmemdup(p, sizeof(*addr), GFP_KERNEL);
        if (!addr)
                return -ENOMEM;
-       memcpy(addr, p, sizeof(*addr));
 
        ret = eth_prepare_mac_addr_change(dev, addr);
        if (ret)