staging: unisys: remove channel.h double negative comparison
authorErik Arfvidson <erik.arfvidson@unisys.com>
Thu, 24 Mar 2016 13:18:09 +0000 (09:18 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
This patch removes the double negative comparisons for function
readb.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/include/channel.h

index 5af59a5..b3c747b 100644 (file)
@@ -411,7 +411,7 @@ spar_channel_client_acquire_os(void __iomem *ch, u8 *id)
                mb(); /* required for channel synch */
        }
        if (readl(&hdr->cli_state_os) == CHANNELCLI_OWNED) {
-               if (readb(&hdr->cli_error_os) != 0) {
+               if (readb(&hdr->cli_error_os)) {
                        /* we are in an error msg throttling state;
                         * come out of it
                         */
@@ -459,7 +459,7 @@ spar_channel_client_acquire_os(void __iomem *ch, u8 *id)
                mb(); /* required for channel synch */
                return 0;
        }
-       if (readb(&hdr->cli_error_os) != 0) {
+       if (readb(&hdr->cli_error_os)) {
                /* we are in an error msg throttling state; come out of it */
                pr_info("%s Channel OS client acquire now successful\n", id);
                writeb(0, &hdr->cli_error_os);
@@ -472,7 +472,7 @@ spar_channel_client_release_os(void __iomem *ch, u8 *id)
 {
        struct channel_header __iomem *hdr = ch;
 
-       if (readb(&hdr->cli_error_os) != 0) {
+       if (readb(&hdr->cli_error_os)) {
                /* we are in an error msg throttling state; come out of it */
                pr_info("%s Channel OS client error state cleared\n", id);
                writeb(0, &hdr->cli_error_os);