Fixed some coverity for resource leak 16/172216/1 accepted/tizen/unified/20180320.141329 submit/tizen/20180318.231541 submit/tizen/20180320.043504
authorhyunuktak <hyunuk.tak@samsung.com>
Tue, 13 Mar 2018 00:35:03 +0000 (09:35 +0900)
committerhyunuktak <hyunuk.tak@samsung.com>
Tue, 13 Mar 2018 00:35:08 +0000 (09:35 +0900)
Change-Id: I21000cd8a58d18b88903e4efcc614122968f0403
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
packaging/capi-network-wifi-manager.spec
src/network_dbus.c

index b6f760b..8689737 100755 (executable)
@@ -1,6 +1,6 @@
 Name:          capi-network-wifi-manager
 Summary:       Network Wi-Fi library in TIZEN C API
-Version:       1.0.31
+Version:       1.0.32
 Release:       1
 Group:         System/Network
 License:       Apache-2.0
index d535c79..4227b3c 100755 (executable)
@@ -2169,12 +2169,10 @@ int _net_dbus_set_bssid(char *bssid)
        const char *prop_key = "SetBSSID";
        const char *method = "SetProperty";
        GVariant *params = NULL;
-       GVariant *param0 = NULL;
 
        WIFI_LOG(WIFI_INFO, "SetBSSID [%s]", bssid);
 
-       param0 = g_variant_new_string(bssid);
-       params = g_variant_new("(sv)", prop_key, param0);
+       params = g_variant_new("(sv)", prop_key, g_variant_new_string(bssid));
 
        message = _net_invoke_dbus_method(CONNMAN_SERVICE,
                        CONNMAN_WIFI_TECHNOLOGY_PREFIX,
@@ -2243,7 +2241,6 @@ int _net_dbus_set_auto_connect_mode(int connect_mode)
 
        GVariant *message = NULL;
        GVariant *params = NULL;
-       GVariant *param0 = NULL;
        net_err_e Error = NET_ERR_NONE;
        char key[] = "AutoConnectMode";
        gboolean value_enable = TRUE;
@@ -2252,12 +2249,8 @@ int _net_dbus_set_auto_connect_mode(int connect_mode)
        WIFI_LOG(WIFI_INFO, "Request auto connect mode [%s]",
                        connect_mode == 1 ? "enable" : "disable");
 
-       if (connect_mode == 1)
-               param0 = g_variant_new_boolean(value_enable);
-       else
-               param0 = g_variant_new_boolean(value_disable);
-
-       params = g_variant_new("(sv)", key, param0);
+       params = g_variant_new("(sv)", key, (connect_mode == 1) ?
+               g_variant_new_boolean(value_enable) : g_variant_new_boolean(value_disable));
 
        message = _net_invoke_dbus_method(CONNMAN_SERVICE,
                        CONNMAN_MANAGER_PATH, CONNMAN_MANAGER_INTERFACE,
@@ -2282,12 +2275,10 @@ int _net_dbus_wifi_set_autoconnect(const char *profile_name, gboolean autoconnec
 
        GVariant *message = NULL;
        GVariant *params = NULL;
-       GVariant *param0 = NULL;
 
        WIFI_LOG(WIFI_INFO, "[%s] auto connect", autoconnect ? "enable" : "disable");
 
-       param0 = g_variant_new_boolean(autoconnect);
-       params = g_variant_new("(sv)", "AutoConnect", param0);
+       params = g_variant_new("(sv)", "AutoConnect", g_variant_new_boolean(autoconnect));
 
        message = _net_invoke_dbus_method(CONNMAN_SERVICE,
                        profile_name, CONNMAN_SERVICE_INTERFACE,