media: rdacm20: Enable GPIO1 explicitly

The MAX9271 GPIO1 line that controls the sensor reset is by default
enabled after a serializer chip reset.

As rdacm20 does not go through an explicit serializer reset, make sure
GPIO1 is enabled to make the camera module driver more robust.

Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver")
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
index 1ed928c4ca70fc5e6f550a4588d23dfc8ac98571..16bcb764b0e0d187ebe813dcfa1701feb27d3861 100644 (file)
--- a/drivers/media/i2c/rdacm20.c
+++ b/drivers/media/i2c/rdacm20.c
@@ -487,9 +487,18 @@ static int rdacm20_initialize(struct rdacm20_device *dev)
         * Reset the sensor by cycling the OV10635 reset signal connected to the
         * MAX9271 GPIO1 and verify communication with the OV10635.
         */
-       max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT);
+       ret = max9271_enable_gpios(dev->serializer, MAX9271_GPIO1OUT);
+       if (ret)
+               return ret;
+
+       ret = max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT);
+       if (ret)
+               return ret;
        usleep_range(10000, 15000);
-       max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT);
+
+       ret = max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT);
+       if (ret)
+               return ret;
        usleep_range(10000, 15000);
 
 again: