media: atomisp: fix uninitialized bug in gmin_get_pmic_id_and_addr()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 12 Oct 2021 08:21:50 +0000 (09:21 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 10:03:09 +0000 (11:03 +0100)
[ Upstream commit cb4d67a998e97365afdf34965b069601da1dae60 ]

The "power" pointer is not initialized on the else path and that would
lead to an Oops.

Link: https://lore.kernel.org/linux-media/20211012082150.GA31086@kili
Fixes: c30f4cb2d4c7 ("media: atomisp: Refactor PMIC detection to a separate function")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

index d8c9e31..62dc06e 100644 (file)
@@ -481,7 +481,7 @@ fail:
 
 static u8 gmin_get_pmic_id_and_addr(struct device *dev)
 {
-       struct i2c_client *power;
+       struct i2c_client *power = NULL;
        static u8 pmic_i2c_addr;
 
        if (pmic_id)