ACPI: button: Use strscpy() instead of strcpy()
authorMuhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>
Sun, 1 Sep 2024 19:18:26 +0000 (00:18 +0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 3 Sep 2024 14:29:16 +0000 (16:29 +0200)
Replace strcpy() with strscpy() in the ACPI button driver.

strcpy() has been deprecated because it is generally unsafe, so help to
eliminate it from the kernel source.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>
Link: https://patch.msgid.link/20240901191826.421488-1-qasim.majeed20@gmail.com
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/button.c

index cc61020756beb8711cc9e703becba6972765fbfa..51470208e6daed524d973027a2e5f9a2d30bc1d1 100644 (file)
@@ -547,20 +547,20 @@ static int acpi_button_add(struct acpi_device *device)
            !strcmp(hid, ACPI_BUTTON_HID_POWERF)) {
                button->type = ACPI_BUTTON_TYPE_POWER;
                handler = acpi_button_notify;
-               strcpy(name, ACPI_BUTTON_DEVICE_NAME_POWER);
+               strscpy(name, ACPI_BUTTON_DEVICE_NAME_POWER, MAX_ACPI_DEVICE_NAME_LEN);
                sprintf(class, "%s/%s",
                        ACPI_BUTTON_CLASS, ACPI_BUTTON_SUBCLASS_POWER);
        } else if (!strcmp(hid, ACPI_BUTTON_HID_SLEEP) ||
                   !strcmp(hid, ACPI_BUTTON_HID_SLEEPF)) {
                button->type = ACPI_BUTTON_TYPE_SLEEP;
                handler = acpi_button_notify;
-               strcpy(name, ACPI_BUTTON_DEVICE_NAME_SLEEP);
+               strscpy(name, ACPI_BUTTON_DEVICE_NAME_SLEEP, MAX_ACPI_DEVICE_NAME_LEN);
                sprintf(class, "%s/%s",
                        ACPI_BUTTON_CLASS, ACPI_BUTTON_SUBCLASS_SLEEP);
        } else if (!strcmp(hid, ACPI_BUTTON_HID_LID)) {
                button->type = ACPI_BUTTON_TYPE_LID;
                handler = acpi_lid_notify;
-               strcpy(name, ACPI_BUTTON_DEVICE_NAME_LID);
+               strscpy(name, ACPI_BUTTON_DEVICE_NAME_LID, MAX_ACPI_DEVICE_NAME_LEN);
                sprintf(class, "%s/%s",
                        ACPI_BUTTON_CLASS, ACPI_BUTTON_SUBCLASS_LID);
                input->open = acpi_lid_input_open;