stk: Fix crash with Modem-Handled SIM Refresh
authorDenis Kenzior <denkenz@gmail.com>
Wed, 2 Jan 2013 03:40:14 +0000 (21:40 -0600)
committerDenis Kenzior <denkenz@gmail.com>
Wed, 2 Jan 2013 03:40:14 +0000 (21:40 -0600)
src/stk.c

index 6278930..7974751 100644 (file)
--- a/src/stk.c
+++ b/src/stk.c
@@ -3095,8 +3095,14 @@ void ofono_stk_proactive_command_handled_notify(struct ofono_stk *stk,
                break;
 
        case STK_COMMAND_TYPE_REFRESH:
+               /*
+                * On a refresh we should not try to free the pending command,
+                * as the stk atom itself likely disappeared as a result.
+                * If it has not, then any subsequent proactive command, or
+                * session end notification will free it anyway
+                */
                handle_command_refresh(stk->pending_cmd, NULL, stk);
-               break;
+               return;
        }
 
 out: