thermal: intel_powerclamp: Use bitmap_zalloc/bitmap_free when applicable
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 26 Sep 2021 07:17:20 +0000 (09:17 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Oct 2021 14:40:22 +0000 (16:40 +0200)
'cpu_clamping_mask' is a bitmap. So use 'bitmap_zalloc()' and
'bitmap_free()' to simplify code, improve the semantic of the code and
avoid some open-coded arithmetic in allocator arguments.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/intel_powerclamp.c

index a5b58ea..9b68489 100644 (file)
@@ -705,10 +705,8 @@ static enum cpuhp_state hp_state;
 static int __init powerclamp_init(void)
 {
        int retval;
-       int bitmap_size;
 
-       bitmap_size = BITS_TO_LONGS(num_possible_cpus()) * sizeof(long);
-       cpu_clamping_mask = kzalloc(bitmap_size, GFP_KERNEL);
+       cpu_clamping_mask = bitmap_zalloc(num_possible_cpus(), GFP_KERNEL);
        if (!cpu_clamping_mask)
                return -ENOMEM;
 
@@ -753,7 +751,7 @@ exit_free_thread:
 exit_unregister:
        cpuhp_remove_state_nocalls(hp_state);
 exit_free:
-       kfree(cpu_clamping_mask);
+       bitmap_free(cpu_clamping_mask);
        return retval;
 }
 module_init(powerclamp_init);
@@ -764,7 +762,7 @@ static void __exit powerclamp_exit(void)
        cpuhp_remove_state_nocalls(hp_state);
        free_percpu(worker_data);
        thermal_cooling_device_unregister(cooling_dev);
-       kfree(cpu_clamping_mask);
+       bitmap_free(cpu_clamping_mask);
 
        cancel_delayed_work_sync(&poll_pkg_cstate_work);
        debugfs_remove_recursive(debug_dir);