Remove FIXME from resolve-supplemental.pl

https://bugs.webkit.org/show_bug.cgi?id=79160

Reviewed by Adam Barth.

The IDL attribute checker has been enabled in all build systems.
This patch removes FIXME in resolve-supplemental.pl.
Also, this patch improves a comment in IDLAttributes.txt.

No tests. No change in behavior.

* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/resolve-supplemental.pl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index b94acaf..7c9bd29 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2012-02-21  Kentaro Hara  <haraken@chromium.org>
+
+        Remove FIXME from resolve-supplemental.pl
+        https://bugs.webkit.org/show_bug.cgi?id=79160
+
+        Reviewed by Adam Barth.
+
+        The IDL attribute checker has been enabled in all build systems.
+        This patch removes FIXME in resolve-supplemental.pl.
+        Also, this patch improves a comment in IDLAttributes.txt.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/IDLAttributes.txt:
+        * bindings/scripts/resolve-supplemental.pl:
+
 2012-02-21  Emil A Eklund  <eae@chromium.org>
 
         Add FractionalLayoutRect for sub-pixel layout

diff --git a/Source/WebCore/bindings/scripts/IDLAttributes.txt b/Source/WebCore/bindings/scripts/IDLAttributes.txt
index 294255e..7e44a8d 100644 (file)
--- a/Source/WebCore/bindings/scripts/IDLAttributes.txt
+++ b/Source/WebCore/bindings/scripts/IDLAttributes.txt
@@ -1,8 +1,10 @@
 #
 # This file describes all IDL attributes.
 # If any IDL file uses an IDL attribute not listed below, the WebKit build will fail.
-# If you want to add a new IDL attribute, you need to add it to this file
-# and the WebKit IDL document (https://trac.webkit.org/wiki/WebKitIDL).
+# If you want to add a new IDL attribute, you need to
+#     (1) add the IDL attribute to this file
+#     (2) add the explanation to the WebKit IDL document (https://trac.webkit.org/wiki/WebKitIDL)
+#     (3) add test cases to run-bindings-tests
 #
 # The syntax of this file is as follows:
 #     - You can write one IDL attribute per one line.

diff --git a/Source/WebCore/bindings/scripts/resolve-supplemental.pl b/Source/WebCore/bindings/scripts/resolve-supplemental.pl
index ada5c63..168b349 100644 (file)
--- a/Source/WebCore/bindings/scripts/resolve-supplemental.pl
+++ b/Source/WebCore/bindings/scripts/resolve-supplemental.pl
@@ -63,14 +63,10 @@ foreach my $idlFile (@idlFiles) {
     $interfaceNameToIdlFile{fileparse(basename($idlFile), ".idl")} = $fullPath;
 }
 
-# FIXME: After enabling the IDL attribute checker on all build systems
-# we can remove the if statement.
-if ($idlAttributesFile) {
-    # Runs the IDL attribute checker.
-    my $idlAttributes = loadIDLAttributes($idlAttributesFile);
-    foreach my $idlFile (keys %documents) {
-        checkIDLAttributes($idlAttributes, $documents{$idlFile}, basename($idlFile));
-    }
+# Runs the IDL attribute checker.
+my $idlAttributes = loadIDLAttributes($idlAttributesFile);
+foreach my $idlFile (keys %documents) {
+    checkIDLAttributes($idlAttributes, $documents{$idlFile}, basename($idlFile));
 }
 
 # Resolves [Supplemental=XXX] dependencies.