drm/sun4i: hdmi: Fix double flag assignation
authorMaxime Ripard <maxime.ripard@bootlin.com>
Sun, 21 Oct 2018 16:34:46 +0000 (18:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:00 +0000 (14:50 +0100)
[ Upstream commit 1e0ff648940e603cab6c52cf3723017d30d78f30 ]

The is_double flag is a boolean currently assigned to the value of the d
variable, that is either 1 or 2. It means that this is_double variable is
always set to true, even though the initial intent was to have it set to
true when d is 2.

Fix this.

Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181021163446.29135-2-maxime.ripard@bootlin.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c

index 3ecffa5..a74adec 100644 (file)
@@ -52,7 +52,7 @@ static unsigned long sun4i_tmds_calc_divider(unsigned long rate,
                            (rate - tmp_rate) < (rate - best_rate)) {
                                best_rate = tmp_rate;
                                best_m = m;
-                               is_double = d;
+                               is_double = (d == 2) ? true : false;
                        }
                }
        }