projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3688433
)
cdc-eem: always use BIT
author
Oliver Neukum
<oneukum@suse.com>
Thu, 30 Jun 2022 11:51:09 +0000
(13:51 +0200)
committer
David S. Miller
<davem@davemloft.net>
Fri, 1 Jul 2022 12:39:03 +0000
(13:39 +0100)
Either you use BIT(x) or 1 << x in the same expression.
Mixing them is ridiculous. Go to BIT()
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_eem.c
patch
|
blob
|
history
diff --git
a/drivers/net/usb/cdc_eem.c
b/drivers/net/usb/cdc_eem.c
index 359ea0d10e597fc7aa5af4b9b12925a28bcaeda9..baa9b14b1644c17b3c3bb6501df22f90fc511e78 100644
(file)
--- a/
drivers/net/usb/cdc_eem.c
+++ b/
drivers/net/usb/cdc_eem.c
@@
-218,7
+218,7
@@
static int eem_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
if (unlikely(!skb2))
goto next;
skb_trim(skb2, len);
- put_unaligned_le16(BIT(15) |
(1 <<
11) | len,
+ put_unaligned_le16(BIT(15) |
BIT(
11) | len,
skb_push(skb2, 2));
eem_linkcmd(dev, skb2);
break;