cdc-eem: always use BIT
authorOliver Neukum <oneukum@suse.com>
Thu, 30 Jun 2022 11:51:09 +0000 (13:51 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Jul 2022 12:39:03 +0000 (13:39 +0100)
Either you use BIT(x) or 1 << x in the same expression.
Mixing them is ridiculous. Go to BIT()

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_eem.c

index 359ea0d..baa9b14 100644 (file)
@@ -218,7 +218,7 @@ static int eem_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
                                if (unlikely(!skb2))
                                        goto next;
                                skb_trim(skb2, len);
-                               put_unaligned_le16(BIT(15) | (1 << 11) | len,
+                               put_unaligned_le16(BIT(15) | BIT(11) | len,
                                                skb_push(skb2, 2));
                                eem_linkcmd(dev, skb2);
                                break;