media: pci: cobalt-i2c.c: fix comparison of 0/1 to bool variable

Fix the following coccinelle reports:

drivers/media/pci/cobalt/cobalt-i2c.c:176:16-21: WARNING:
Comparison of 0/1 to bool variable
drivers/media/pci/cobalt/cobalt-i2c.c:180:29-33: WARNING:
Comparison of 0/1 to bool variable
drivers/media/pci/cobalt/cobalt-i2c.c:121:16-21: WARNING:
Comparison of 0/1 to bool variable
drivers/media/pci/cobalt/cobalt-i2c.c:125:29-33: WARNING:
Comparison of 0/1 to bool variable

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/pci/cobalt/cobalt-i2c.c b/drivers/media/pci/cobalt/cobalt-i2c.c
index c374dae78bf7093bdc62d4cb02320f00dd78190f..10c9ee33f73ef0683303630c3045eb39634c9a35 100644 (file)
--- a/drivers/media/pci/cobalt/cobalt-i2c.c
+++ b/drivers/media/pci/cobalt/cobalt-i2c.c
@@ -118,11 +118,11 @@ static int cobalt_tx_bytes(struct cobalt_i2c_regs __iomem *regs,
                iowrite8(data[i], &regs->txr_rxr);
 
                /* Setup command */
-               if (i == 0 && start != 0) {
+               if (i == 0 && start) {
                        /* Write + Start */
                        cmd = M00018_CR_BITMAP_WR_MSK |
                              M00018_CR_BITMAP_STA_MSK;
-               } else if (i == len - 1 && stop != 0) {
+               } else if (i == len - 1 && stop) {
                        /* Write + Stop */
                        cmd = M00018_CR_BITMAP_WR_MSK |
                              M00018_CR_BITMAP_STO_MSK;
@@ -173,11 +173,11 @@ static int cobalt_rx_bytes(struct cobalt_i2c_regs __iomem *regs,
 
        for (i = 0; i < len; i++) {
                /* Setup command */
-               if (i == 0 && start != 0) {
+               if (i == 0 && start) {
                        /* Read + Start */
                        cmd = M00018_CR_BITMAP_RD_MSK |
                              M00018_CR_BITMAP_STA_MSK;
-               } else if (i == len - 1 && stop != 0) {
+               } else if (i == len - 1 && stop) {
                        /* Read + Stop */
                        cmd = M00018_CR_BITMAP_RD_MSK |
                              M00018_CR_BITMAP_STO_MSK;