projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
00eb36d
)
platform/chrome: cros_ec_proto: return -EAGAIN when retries timed out
author
Tzung-Bi Shih
<tzungbi@kernel.org>
Mon, 18 Jul 2022 05:09:12 +0000
(
05:09
+0000)
committer
Tzung-Bi Shih
<tzungbi@kernel.org>
Wed, 20 Jul 2022 01:22:58 +0000
(
01:22
+0000)
While EC_COMMS_STATUS_PROCESSING flag is still on after it tries
EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS,
cros_ec_wait_until_complete() doesn't return an error code.
Return -EAGAIN in the case instead.
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link:
https://lore.kernel.org/r/20220718050914.2267370-9-tzungbi@kernel.org
drivers/platform/chrome/cros_ec_proto.c
patch
|
blob
|
history
diff --git
a/drivers/platform/chrome/cros_ec_proto.c
b/drivers/platform/chrome/cros_ec_proto.c
index
a6ad7f7
..
9dec475
100644
(file)
--- a/
drivers/platform/chrome/cros_ec_proto.c
+++ b/
drivers/platform/chrome/cros_ec_proto.c
@@
-167,6
+167,9
@@
static int cros_ec_wait_until_complete(struct cros_ec_device *ec_dev, uint32_t *
return ret;
}
+ if (i >= EC_COMMAND_RETRIES)
+ ret = -EAGAIN;
+
return ret;
}