ath10k: fix a check patch warning returnNonBoolInBooleanFunction of sdio.c
authorWen Gong <wgong@codeaurora.org>
Mon, 7 Dec 2020 14:15:58 +0000 (16:15 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 7 Dec 2020 16:06:42 +0000 (18:06 +0200)
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
drivers/net/wireless/ath/ath10k/sdio.c:2234:2:
warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;

Reported-by: kernel test robot <rong.a.chen@intel.com>
Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049

Signed-off-by: Wen Gong <wgong@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1606103240-9868-1-git-send-email-wgong@codeaurora.org
drivers/net/wireless/ath/ath10k/sdio.c

index aa1f860..15474c1 100644 (file)
@@ -2237,7 +2237,7 @@ static bool ath10k_sdio_is_fast_dump_supported(struct ath10k *ar)
 
        ath10k_dbg(ar, ATH10K_DBG_SDIO, "sdio hi_option_flag2 %x\n", param);
 
-       return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
+       return !!(param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW);
 }
 
 static void ath10k_sdio_dump_registers(struct ath10k *ar,