adaptivedemux2: Fix collection leaks

* The collection on the period was never unreffed
* The collection in the message handler was never unreffed

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3319>

diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-period.c b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-period.c
index 2adf12d..35925cf 100644 (file)
--- a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-period.c
+++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux-period.c
@@ -53,6 +53,9 @@ _demux_period_free (GstAdaptiveDemuxPeriod * period)
   /* Disable and remove all streams and tracks. */
   g_list_free_full (period->streams, (GDestroyNotify) gst_object_unref);
 
+  if (period->collection)
+    gst_object_unref (period->collection);
+
   /* Theoretically all tracks should have gone by now */
   GST_DEBUG ("Disabling and removing all tracks");
   g_list_free_full (period->tracks,

diff --git a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c
index 07619bc..622ebf2 100644 (file)
--- a/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c
+++ b/subprojects/gst-plugins-good/ext/adaptivedemux2/gstadaptivedemux.c
@@ -1509,6 +1509,8 @@ gst_adaptive_demux_handle_stream_collection_msg (GstAdaptiveDemux * demux,
 beach:
   GST_MANIFEST_UNLOCK (demux);
 
+  if (collection)
+    gst_object_unref (collection);
   gst_message_unref (msg);
   msg = NULL;
 }