cifs: remove rfc1002 header from smb2_echo_req
authorRonnie Sahlberg <lsahlber@redhat.com>
Thu, 9 Nov 2017 01:14:21 +0000 (12:14 +1100)
committerSteve French <smfrench@gmail.com>
Thu, 25 Jan 2018 01:49:04 +0000 (19:49 -0600)
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Pavel Shilovsky <pshilov@microsoft.com>
fs/cifs/smb2pdu.c
fs/cifs/smb2pdu.h

index 904766a..d00d7da 100644 (file)
@@ -2397,6 +2397,8 @@ SMB2_echo(struct TCP_Server_Info *server)
        struct kvec iov[2];
        struct smb_rqst rqst = { .rq_iov = iov,
                                 .rq_nvec = 2 };
+       unsigned int total_len;
+       __be32 rfc1002_marker;
 
        cifs_dbg(FYI, "In echo request\n");
 
@@ -2406,17 +2408,17 @@ SMB2_echo(struct TCP_Server_Info *server)
                return rc;
        }
 
-       rc = small_smb2_init(SMB2_ECHO, NULL, (void **)&req);
+       rc = smb2_plain_req_init(SMB2_ECHO, NULL, (void **)&req, &total_len);
        if (rc)
                return rc;
 
-       req->hdr.sync_hdr.CreditRequest = cpu_to_le16(1);
+       req->sync_hdr.CreditRequest = cpu_to_le16(1);
 
-       /* 4 for rfc1002 length field */
        iov[0].iov_len = 4;
-       iov[0].iov_base = (char *)req;
-       iov[1].iov_len = get_rfc1002_length(req);
-       iov[1].iov_base = (char *)req + 4;
+       rfc1002_marker = cpu_to_be32(total_len);
+       iov[0].iov_base = &rfc1002_marker;
+       iov[1].iov_len = total_len;
+       iov[1].iov_base = (char *)req;
 
        rc = cifs_call_async(server, &rqst, NULL, smb2_echo_callback, NULL,
                             server, CIFS_ECHO_OP);
index 2c743d3..b22bf8c 100644 (file)
@@ -924,7 +924,7 @@ struct smb2_lock_rsp {
 } __packed;
 
 struct smb2_echo_req {
-       struct smb2_hdr hdr;
+       struct smb2_sync_hdr sync_hdr;
        __le16 StructureSize;   /* Must be 4 */
        __u16  Reserved;
 } __packed;