Fix UNKNOWN types in dumpheap -stat (#355)
authorMike McLaughlin <mikem@microsoft.com>
Fri, 21 Jun 2019 01:06:28 +0000 (18:06 -0700)
committerGitHub <noreply@github.com>
Fri, 21 Jun 2019 01:06:28 +0000 (18:06 -0700)
Issue https://github.com/dotnet/diagnostics/issues/350

src/SOS/Strike/util.cpp

index f45ecc08029f2d9ed8989f73dbc66c353f501bfc..f0843b6bc286be642c72540b2e70076acf57e0a2 100644 (file)
@@ -6333,20 +6333,8 @@ void PopulateMetadataRegions()
                 {
                     if (moduleData.metadataStart != 0)
                     {
-                        bool add = false;
-                        STORAGESIGNATURE header;
-                        if (SUCCEEDED(g_ExtData->ReadVirtual(moduleData.metadataStart, (PVOID)&header, sizeof(header), NULL)))
-                        {
-                            add = header.lSignature != STORAGE_MAGIC_SIG;
-                        }
-                        else {
-                            add = true;
-                        }
-                        if (add)
-                        {
-                            MemoryRegion region(moduleData.metadataStart, moduleData.metadataStart + moduleData.metadataSize);
-                            g_metadataRegions.insert(region);
-                        }
+                        MemoryRegion region(moduleData.metadataStart, moduleData.metadataStart + moduleData.metadataSize);
+                        g_metadataRegions.insert(region);
 #ifdef METADATA_REGION_LOGGING
                         ArrayHolder<WCHAR> name = new WCHAR[MAX_LONGPATH];
                         name[0] = '\0';