tools lib traceevent: Fix and cleanup kvm_nested_vmexit tracepoints
authorJan Kiszka <jan.kiszka@siemens.com>
Fri, 13 Jun 2014 02:10:06 +0000 (22:10 -0400)
committerJiri Olsa <jolsa@kernel.org>
Thu, 19 Jun 2014 16:18:30 +0000 (18:18 +0200)
Fix several issues of kvm_nested_vmexit[_inject]: field width aren't
supported with pevent_print, rip was printed twice/incorrectly, SVM ISA
was hard-coded, we don't use ':' to separate field names.

Link: http://lkml.kernel.org/r/8e6c02b22ea8136c139a91c69d6cc73b8c5c184b.1388855989.git.jan.kiszka@web.de
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
tools/lib/traceevent/plugin_kvm.c

index 0d43783..0575e59 100644 (file)
@@ -330,19 +330,13 @@ static int kvm_emulate_insn_handler(struct trace_seq *s,
 static int kvm_nested_vmexit_inject_handler(struct trace_seq *s, struct pevent_record *record,
                                            struct event_format *event, void *context)
 {
-       unsigned long long val;
-
-       pevent_print_num_field(s, " rip %0x016llx", event, "rip", record, 1);
-
-       if (pevent_get_field_val(s, event, "exit_code", record, &val, 1) < 0)
+       if (print_exit_reason(s, record, event, "exit_code") < 0)
                return -1;
 
-       trace_seq_printf(s, "reason %s", find_exit_reason(2, val));
-
-       pevent_print_num_field(s, " ext_inf1: %0x016llx", event, "exit_info1", record, 1);
-       pevent_print_num_field(s, " ext_inf2: %0x016llx", event, "exit_info2", record, 1);
-       pevent_print_num_field(s, " ext_int: %0x016llx", event, "exit_int_info", record, 1);
-       pevent_print_num_field(s, " ext_int_err: %0x016llx", event, "exit_int_info_err", record, 1);
+       pevent_print_num_field(s, " info1 %llx", event, "exit_info1", record, 1);
+       pevent_print_num_field(s, " info2 %llx", event, "exit_info2", record, 1);
+       pevent_print_num_field(s, " int_info %llx", event, "exit_int_info", record, 1);
+       pevent_print_num_field(s, " int_info_err %llx", event, "exit_int_info_err", record, 1);
 
        return 0;
 }
@@ -350,7 +344,7 @@ static int kvm_nested_vmexit_inject_handler(struct trace_seq *s, struct pevent_r
 static int kvm_nested_vmexit_handler(struct trace_seq *s, struct pevent_record *record,
                                     struct event_format *event, void *context)
 {
-       pevent_print_num_field(s, " rip %0x016llx", event, "rip", record, 1);
+       pevent_print_num_field(s, "rip %lx ", event, "rip", record, 1);
 
        return kvm_nested_vmexit_inject_handler(s, record, event, context);
 }