soundwire: cadence: Fix error check in cdns_xfer_msg()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Sat, 17 Sep 2022 15:48:21 +0000 (16:48 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 20 Sep 2022 05:07:14 +0000 (10:37 +0530)
_cdns_xfer_msg() returns an sdw_command_response value, not a
negative error code.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220917154822.690472-1-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c

index ca241bbeadd9355d59a71dacfff622a5812bc004..3543a923ee6b49787b4afe75eb6d090fe16f1efb 100644 (file)
@@ -708,7 +708,7 @@ cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg)
        for (i = 0; i < msg->len / CDNS_MCP_CMD_LEN; i++) {
                ret = _cdns_xfer_msg(cdns, msg, cmd, i * CDNS_MCP_CMD_LEN,
                                     CDNS_MCP_CMD_LEN, false);
-               if (ret < 0)
+               if (ret != SDW_CMD_OK)
                        goto exit;
        }