fw_base: Don't mark fw_platform_init as both global and weak
authorJessica Clarke <jrtc27@jrtc27.com>
Sun, 11 Jul 2021 02:28:19 +0000 (03:28 +0100)
committerAnup Patel <anup@brainfault.org>
Sun, 11 Jul 2021 11:50:42 +0000 (17:20 +0530)
These are mutually exclusive. GNU as and LLVM both let later binding
directives override earlier ones so this works as intended, but LLVM 12
turned this into a warning as there's no good reason to do such a thing
and could be a potential bug. Thus, remove the redundant and incorrect
.globl directive for fw_platform_init.

Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Anup Patel <anup.patel@wdc.com>
firmware/fw_base.S

index 8e40562..a1213e3 100644 (file)
@@ -558,7 +558,6 @@ _start_hang:
 
        .section .entry, "ax", %progbits
        .align 3
-       .globl fw_platform_init
        .weak fw_platform_init
 fw_platform_init:
        add     a0, a1, zero