tools: Avoid showing return value of clock_gettime()

This value is either 0 for success or -1 for error. Coverity reports that
"ret" is passed to a parameter that cannot be negative, pointing to the
condition 'if (ret < 0)'.

Adjust it to just check for non-zero and avoid showing -1 in the error
message, which is pointless. Perhaps these changes will molify Coverity.

Reported-by: Coverity (CID: 312956)
Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/tools/image-host.c b/tools/image-host.c
index 7309546..d3a882e 100644 (file)
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -329,7 +329,7 @@ static int get_random_data(void *data, int size)
 {
        unsigned char *tmp = data;
        struct timespec date;
-       int i, ret = 0;
+       int i, ret;
 
        if (!tmp) {
                printf("%s: pointer data is NULL\n", __func__);
@@ -338,9 +338,9 @@ static int get_random_data(void *data, int size)
        }
 
        ret = clock_gettime(CLOCK_MONOTONIC, &date);
-       if (ret < 0) {
-               printf("%s: clock_gettime has failed (err=%d, str=%s)\n",
-                      __func__, ret, strerror(errno));
+       if (ret) {
+               printf("%s: clock_gettime has failed (%s)\n", __func__,
+                      strerror(errno));
                goto out;
        }