Fixed the build error using gcc 13

- Remove unnecessary std::move call

Change-Id: I9c338e46da26342815e23bd7417ae5f18b1437b7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/idlc/gen/dart_gen_base.cc b/idlc/gen/dart_gen_base.cc
index b6924f2c464c3b7ae3af7290782585b7e7446da9..3ba526b6fcfe50e19e9dc28e65ef3c43359d190d 100644 (file)
--- a/idlc/gen/dart_gen_base.cc
+++ b/idlc/gen/dart_gen_base.cc
@@ -519,7 +519,7 @@ std::string DartGeneratorBase::SmartIndent(std::string lines) {
     }
 
     if (line.empty() || std::all_of(line.begin(), line.end(), isspace)) {
-      std::string new_line = std::move(Trim(next_line));
+      std::string new_line = Trim(next_line);
       if (new_line.empty() || new_line.find('}') != std::string::npos ||
           std::all_of(new_line.begin(), new_line.end(), isspace)) {
         line = std::move(new_line);

diff --git a/idlc/gen/dart_proxy_gen.cc b/idlc/gen/dart_proxy_gen.cc
index 538f3b2a7ac84decb5ac1ea08df0072961e5a086..c7936743ad656e2b06df7b9625403aeff9bc3968 100644 (file)
--- a/idlc/gen/dart_proxy_gen.cc
+++ b/idlc/gen/dart_proxy_gen.cc
@@ -169,7 +169,7 @@ std::string DartProxyGen::GenMethodParcelRead(const Declaration& decl) {
   if (decl.GetMethodType() == Declaration::MethodType::ASYNC)
     return {};
 
-  std::string code = std::move(GenMethodResultParcelRead(decl));
+  std::string code = GenMethodResultParcelRead(decl);
   code += GenMethodOutParamParcelRead(decl);
   code = ReplaceAll(CB_METHOD_PARCEL_READ, "<PARCEL_READ>", code);
   return code;

diff --git a/idlc/gen/dart_stub_gen.cc b/idlc/gen/dart_stub_gen.cc
index 199f7d7a9a12aa2dcb9ee110e1d47f7a41e4eec2..a547621ad1ce36179b0ec4b8796e515f5913cd99 100644 (file)
--- a/idlc/gen/dart_stub_gen.cc
+++ b/idlc/gen/dart_stub_gen.cc
@@ -204,7 +204,7 @@ std::string DartStubGen::GenMethodHandlerParcelWrite(const Declaration& decl) {
   if (decl.GetMethodType() == Declaration::MethodType::ASYNC)
     return {};
 
-  std::string code = std::move(GenMethodHandlerResultParcelWrite(decl));
+  std::string code = GenMethodHandlerResultParcelWrite(decl);
   code += GenMethodHandlerOutParamParcelWrite(decl);
   code = ReplaceAll(CB_METHOD_HANDLER_PARCEL_WRITE, "<PARCEL_WRITE>", code);
   return code;
@@ -277,7 +277,7 @@ void DartStubGen::GenServiceBase(std::ofstream& stream,
   ReplaceAll(CB_SERVICE_BASE, "<METHOD_DECLS>",
       GenServiceBaseMethodDecls(iface))
       .Transform([&](std::string str) {
-        return SmartIndent(std::move(RemoveLine(std::move(str))));
+        return SmartIndent(RemoveLine(std::move(str)));
       })
       .Out(stream);
 }

diff --git a/idlc/gen_cion/dart_cion_gen_base.cc b/idlc/gen_cion/dart_cion_gen_base.cc
index 8869394949b9a0c28465a49b3cda6f7e620c5cbf..be42069010e5bb4bbd0118720038be229a072095 100644 (file)
--- a/idlc/gen_cion/dart_cion_gen_base.cc
+++ b/idlc/gen_cion/dart_cion_gen_base.cc
@@ -533,7 +533,7 @@ std::string DartCionGeneratorBase::SmartIndent(std::string lines) {
     }
 
     if (line.empty() || std::all_of(line.begin(), line.end(), isspace)) {
-      std::string new_line = std::move(Trim(next_line));
+      std::string new_line = Trim(next_line);
       if (new_line.empty() || new_line.find('}') != std::string::npos ||
           std::all_of(new_line.begin(), new_line.end(), isspace)) {
         line = std::move(new_line);

diff --git a/idlc/gen_cion/dart_cion_proxy_gen.cc b/idlc/gen_cion/dart_cion_proxy_gen.cc
index ce62622dcb1b014afbe36e798216e384aa35072d..e2a74d1b0fa6f72cfc520598d84d3bc60ffe3062 100644 (file)
--- a/idlc/gen_cion/dart_cion_proxy_gen.cc
+++ b/idlc/gen_cion/dart_cion_proxy_gen.cc
@@ -184,7 +184,7 @@ std::string DartCionProxyGen::GenMethodParcelWrite(const Declaration& decl) {
     if (has_file)
       code = GetFileSharing(code,"_client.send(payload);");
   } else {
-    std::string read_code = std::move(GenMethodResultParcelRead(decl));
+    std::string read_code = GenMethodResultParcelRead(decl);
     read_code += GenMethodOutParamParcelRead(decl);
     code = ReplaceAll(CB_METHOD_PARCEL_WRITE_AND_READ,
                       {{"<PARCEL_WRITE>", code},

diff --git a/idlc/gen_cion/dart_cion_stub_gen.cc b/idlc/gen_cion/dart_cion_stub_gen.cc
index bb7afd7f7645142d3017e864cc3ea57f7ac2fbf2..4ca293faf489cc9d4880e2afeb98451252b46e8c 100644 (file)
--- a/idlc/gen_cion/dart_cion_stub_gen.cc
+++ b/idlc/gen_cion/dart_cion_stub_gen.cc
@@ -227,7 +227,7 @@ std::string DartCionStubGen::GenMethodHandlerParcelWrite(const Declaration& decl
   if (decl.GetMethodType() == Declaration::MethodType::ASYNC)
     return {};
 
-  std::string code = std::move(GenMethodHandlerResultParcelWrite(decl));
+  std::string code = GenMethodHandlerResultParcelWrite(decl);
   code += GenMethodHandlerOutParamParcelWrite(decl);
 
   if (HasFile(decl.GetType()))
@@ -312,7 +312,7 @@ void DartCionStubGen::GenServiceBase(std::ofstream& stream,
         { "<METHOD_DECLS>", GenServiceBaseMethodDecls(iface) }
       })
       .Transform([&](std::string str) {
-        return SmartIndent(std::move(RemoveLine(std::move(str))));
+        return SmartIndent(RemoveLine(std::move(str)));
       })
       .Out(stream);
 }