[media] tuners/tda18271: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:17 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 21:01:13 +0000 (19:01 -0200)
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/tuners/tda18271-maps.c

index fb881c6..b62e925 100644 (file)
@@ -1290,13 +1290,11 @@ int tda18271_assign_map_layout(struct dvb_frontend *fe)
        switch (priv->id) {
        case TDA18271HDC1:
                priv->maps = &tda18271c1_map_layout;
-               memcpy(&priv->std, &tda18271c1_std_map,
-                      sizeof(struct tda18271_std_map));
+               priv->std = tda18271c1_std_map;
                break;
        case TDA18271HDC2:
                priv->maps = &tda18271c2_map_layout;
-               memcpy(&priv->std, &tda18271c2_std_map,
-                      sizeof(struct tda18271_std_map));
+               priv->std = tda18271c2_std_map;
                break;
        default:
                ret = -EINVAL;