staging: rtl8723bs: fix coding style for if comparisions
authorShreyansh Chouhan <chouhan.shreyansh630@gmail.com>
Sat, 15 May 2021 08:14:46 +0000 (13:44 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 15:49:10 +0000 (17:49 +0200)
Placed constants on the right side of the equality tests in rtw_xmit.c

Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
Link: https://lore.kernel.org/r/20210515081446.676500-1-chouhan.shreyansh630@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_xmit.c

index f21a814..e37c4ba 100644 (file)
@@ -645,7 +645,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
 
        pattrib->pktlen = pktfile.pkt_len;
 
-       if (ETH_P_IP == pattrib->ether_type) {
+       if (pattrib->ether_type == ETH_P_IP) {
                /*  The following is for DHCP and ARP packet, we use cck1M to tx these packets and let LPS awake some time */
                /*  to prevent DHCP protocol fail */
 
@@ -655,7 +655,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
 
                pattrib->dhcp_pkt = 0;
                if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */
-                       if (ETH_P_IP == pattrib->ether_type) {/*  IP header */
+                       if (pattrib->ether_type == ETH_P_IP) {/*  IP header */
                                if (((tmp[21] == 68) && (tmp[23] == 67)) ||
                                        ((tmp[21] == 67) && (tmp[23] == 68))) {
                                        /*  68 : UDP BOOTP client */
@@ -673,7 +673,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
                        if (piphdr->protocol == 0x1) /*  protocol type in ip header 0x1 is ICMP */
                                pattrib->icmp_pkt = 1;
                }
-       } else if (0x888e == pattrib->ether_type) {
+       } else if (pattrib->ether_type == 0x888e) {
                netdev_dbg(padapter->pnetdev, "send eapol packet\n");
        }