ALSA: aloop: Use DIV_ROUND_UP() instead of open-coding it
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 23 Dec 2020 17:22:13 +0000 (18:22 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 25 Dec 2020 08:11:47 +0000 (09:11 +0100)
Use DIV_ROUND_UP() instead of open-coding it. This documents intent
and makes it more clear what is going on for the casual reviewer.

Generated using the following the Coccinelle semantic patch.

// <smpl>
@@
expression x, y;
@@
-(((x) + (y) - 1) / (y))
+DIV_ROUND_UP(x, y)
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201223172229.781-2-lars@metafoo.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/aloop.c

index 702f91b..8a24e5a 100644 (file)
@@ -219,7 +219,7 @@ static int loopback_jiffies_timer_start(struct loopback_pcm *dpcm)
                dpcm->period_update_pending = 1;
        }
        tick = dpcm->period_size_frac - dpcm->irq_pos;
-       tick = (tick + dpcm->pcm_bps - 1) / dpcm->pcm_bps;
+       tick = DIV_ROUND_UP(tick, dpcm->pcm_bps);
        mod_timer(&dpcm->timer, jiffies + tick);
 
        return 0;