locking/atomic: scripts: factor out order template generation
authorMark Rutland <mark.rutland@arm.com>
Mon, 5 Jun 2023 07:01:13 +0000 (08:01 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 5 Jun 2023 07:57:19 +0000 (09:57 +0200)
Currently gen_proto_order_variants() hard codes the path for the templates used
for order fallbacks. Factor this out into a helper so that it can be reused
elsewhere.

This results in no change to the generated headers, so there should be
no functional change as a result of this patch.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230605070124.3741859-17-mark.rutland@arm.com
scripts/atomic/gen-atomic-fallback.sh

index 7a6bcea..3373308 100755 (executable)
@@ -32,6 +32,20 @@ gen_template_fallback()
        fi
 }
 
+#gen_order_fallback(meta, pfx, name, sfx, order, atomic, int, args...)
+gen_order_fallback()
+{
+       local meta="$1"; shift
+       local pfx="$1"; shift
+       local name="$1"; shift
+       local sfx="$1"; shift
+       local order="$1"; shift
+
+       local tmpl_order=${order#_}
+       local tmpl="${ATOMICDIR}/fallbacks/${tmpl_order:-fence}"
+       gen_template_fallback "${tmpl}" "${meta}" "${pfx}" "${name}" "${sfx}" "${order}" "$@"
+}
+
 #gen_proto_fallback(meta, pfx, name, sfx, order, atomic, int, args...)
 gen_proto_fallback()
 {
@@ -56,20 +70,6 @@ cat << EOF
 EOF
 }
 
-gen_proto_order_variant()
-{
-       local meta="$1"; shift
-       local pfx="$1"; shift
-       local name="$1"; shift
-       local sfx="$1"; shift
-       local order="$1"; shift
-       local atomic="$1"
-
-       local basename="arch_${atomic}_${pfx}${name}${sfx}"
-
-       printf "#define ${basename}${order} ${basename}${order}\n"
-}
-
 #gen_proto_order_variants(meta, pfx, name, sfx, atomic, int, args...)
 gen_proto_order_variants()
 {
@@ -117,9 +117,9 @@ gen_proto_order_variants()
 
        printf "#else /* ${basename}_relaxed */\n\n"
 
-       gen_template_fallback "${ATOMICDIR}/fallbacks/acquire"  "${meta}" "${pfx}" "${name}" "${sfx}" "_acquire" "$@"
-       gen_template_fallback "${ATOMICDIR}/fallbacks/release"  "${meta}" "${pfx}" "${name}" "${sfx}" "_release" "$@"
-       gen_template_fallback "${ATOMICDIR}/fallbacks/fence"  "${meta}" "${pfx}" "${name}" "${sfx}" "" "$@"
+       gen_order_fallback "${meta}" "${pfx}" "${name}" "${sfx}" "_acquire" "$@"
+       gen_order_fallback "${meta}" "${pfx}" "${name}" "${sfx}" "_release" "$@"
+       gen_order_fallback "${meta}" "${pfx}" "${name}" "${sfx}" "" "$@"
 
        printf "#endif /* ${basename}_relaxed */\n\n"
 }