gpu: drm: img: fix potential NULL pointer dereference 53/319853/1
authorMarek Szyprowski <m.szyprowski@samsung.com>
Mon, 4 Nov 2024 15:23:33 +0000 (16:23 +0100)
committerMarek Szyprowski <m.szyprowski@samsung.com>
Mon, 4 Nov 2024 22:37:15 +0000 (23:37 +0100)
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Change-Id: I519c2289c9659deab1e348ef88ab05668eb9c8f7

drivers/gpu/drm/img-rogue/module_common.c

index aa7ace0dabd116177c4021478f497698d5f1ac0d..76d0dac52e34317e56a981c4373722b3e3ce5d38 100644 (file)
@@ -158,13 +158,18 @@ CONNECTION_DATA *LinuxSyncConnectionFromFile(struct file *pFile)
        if (pFile)
        {
                struct drm_file *psDRMFile = pFile->private_data;
-               PVRSRV_CONNECTION_PRIV *psConnectionPriv = (PVRSRV_CONNECTION_PRIV*)psDRMFile->driver_priv;
 
+               if (psDRMFile) {
+                       PVRSRV_CONNECTION_PRIV *psConnectionPriv = (PVRSRV_CONNECTION_PRIV*)psDRMFile->driver_priv;
+
+                       if (psConnectionPriv) {
 #if (PVRSRV_DEVICE_INIT_MODE == PVRSRV_LINUX_DEV_INIT_ON_CONNECT)
-               return (CONNECTION_DATA*)psConnectionPriv->pvConnectionData;
+                               return (CONNECTION_DATA*)psConnectionPriv->pvConnectionData;
 #else
-               return (CONNECTION_DATA*)psConnectionPriv->pvSyncConnectionData;
+                               return (CONNECTION_DATA*)psConnectionPriv->pvSyncConnectionData;
 #endif
+                       }
+               }
        }
 
        return NULL;