net: korina: fix return value
authorVincent Stehlé <vincent.stehle@laposte.net>
Mon, 14 Dec 2020 22:09:52 +0000 (23:09 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 16 Dec 2020 23:01:07 +0000 (15:01 -0800)
The ndo_start_xmit() method must not attempt to free the skb to transmit
when returning NETDEV_TX_BUSY. Therefore, make sure the
korina_send_packet() function returns NETDEV_TX_OK when it frees a packet.

Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20201214220952.19935-1-vincent.stehle@laposte.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/korina.c

index bf48f0d..9251619 100644 (file)
@@ -219,7 +219,7 @@ static int korina_send_packet(struct sk_buff *skb, struct net_device *dev)
                        dev_kfree_skb_any(skb);
                        spin_unlock_irqrestore(&lp->lock, flags);
 
-                       return NETDEV_TX_BUSY;
+                       return NETDEV_TX_OK;
                }
        }