soc: sifive: ccache: fix missing iounmap() in error path in sifive_ccache_init()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 18 Oct 2022 02:31:47 +0000 (10:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:31:50 +0000 (13:31 +0100)
[ Upstream commit 73e770f085023da327dc9ffeb6cd96b0bb22d97e ]

Add missing iounmap() before return error from sifive_ccache_init().

Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/sifive/sifive_ccache.c

index 1c17115..25019c1 100644 (file)
@@ -222,13 +222,16 @@ static int __init sifive_ccache_init(void)
        if (!ccache_base)
                return -ENOMEM;
 
-       if (of_property_read_u32(np, "cache-level", &level))
-               return -ENOENT;
+       if (of_property_read_u32(np, "cache-level", &level)) {
+               rc = -ENOENT;
+               goto err_unmap;
+       }
 
        intr_num = of_property_count_u32_elems(np, "interrupts");
        if (!intr_num) {
                pr_err("No interrupts property\n");
-               return -ENODEV;
+               rc = -ENODEV;
+               goto err_unmap;
        }
 
        for (i = 0; i < intr_num; i++) {
@@ -237,7 +240,7 @@ static int __init sifive_ccache_init(void)
                                 NULL);
                if (rc) {
                        pr_err("Could not request IRQ %d\n", g_irq[i]);
-                       return rc;
+                       goto err_unmap;
                }
        }
 
@@ -250,6 +253,10 @@ static int __init sifive_ccache_init(void)
        setup_sifive_debug();
 #endif
        return 0;
+
+err_unmap:
+       iounmap(ccache_base);
+       return rc;
 }
 
 device_initcall(sifive_ccache_init);