hwrng: pic32 - Use device-managed registration API
authorTian Tao <tiantao6@hisilicon.com>
Mon, 1 Mar 2021 03:24:53 +0000 (11:24 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 12 Mar 2021 13:04:00 +0000 (00:04 +1100)
Use devm_hwrng_register to get rid of manual unregistration.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/pic32-rng.c

index e8210c1..99c8bd0 100644 (file)
@@ -96,7 +96,7 @@ static int pic32_rng_probe(struct platform_device *pdev)
        priv->rng.name = pdev->name;
        priv->rng.read = pic32_rng_read;
 
-       ret = hwrng_register(&priv->rng);
+       ret = devm_hwrng_register(&pdev->dev, &priv->rng);
        if (ret)
                goto err_register;
 
@@ -113,7 +113,6 @@ static int pic32_rng_remove(struct platform_device *pdev)
 {
        struct pic32_rng *rng = platform_get_drvdata(pdev);
 
-       hwrng_unregister(&rng->rng);
        writel(0, rng->base + RNGCON);
        clk_disable_unprepare(rng->clk);
        return 0;