staging: fieldbus: anybuss: jump to correct label in an error path
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Mon, 12 Oct 2020 13:24:04 +0000 (21:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Oct 2020 12:24:51 +0000 (13:24 +0100)
In current code, controller_probe() misses to call ida_simple_remove()
in an error path. Jump to correct label to fix it.

Fixes: 17614978ed34 ("staging: fieldbus: anybus-s: support the Arcx anybus controller")
Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20201012132404.113031-1-jingxiangfeng@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fieldbus/anybuss/arcx-anybus.c

index 5b8d0ba..b5fded1 100644 (file)
@@ -293,7 +293,7 @@ static int controller_probe(struct platform_device *pdev)
        regulator = devm_regulator_register(dev, &can_power_desc, &config);
        if (IS_ERR(regulator)) {
                err = PTR_ERR(regulator);
-               goto out_reset;
+               goto out_ida;
        }
        /* make controller info visible to userspace */
        cd->class_dev = kzalloc(sizeof(*cd->class_dev), GFP_KERNEL);