arch_topology: Remove unused topology_set_thermal_pressure() and related
authorLukasz Luba <lukasz.luba@arm.com>
Tue, 9 Nov 2021 19:57:14 +0000 (19:57 +0000)
committerViresh Kumar <viresh.kumar@linaro.org>
Tue, 23 Nov 2021 09:40:26 +0000 (15:10 +0530)
There is no need of this function (and related) since code has been
converted to use the new arch_update_thermal_pressure() API. The old
code can be removed.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
arch/arm/include/asm/topology.h
arch/arm64/include/asm/topology.h
drivers/base/arch_topology.c
include/linux/arch_topology.h
include/linux/sched/topology.h
init/Kconfig

index f1eafac..c7d2510 100644 (file)
@@ -23,7 +23,6 @@
 
 /* Replace task scheduler's default thermal pressure API */
 #define arch_scale_thermal_pressure topology_get_thermal_pressure
-#define arch_set_thermal_pressure   topology_set_thermal_pressure
 #define arch_update_thermal_pressure   topology_update_thermal_pressure
 
 #else
index 7a421cb..f386b90 100644 (file)
@@ -32,7 +32,6 @@ void update_freq_counters_refs(void);
 
 /* Replace task scheduler's default thermal pressure API */
 #define arch_scale_thermal_pressure topology_get_thermal_pressure
-#define arch_set_thermal_pressure   topology_set_thermal_pressure
 #define arch_update_thermal_pressure   topology_update_thermal_pressure
 
 #include <asm-generic/topology.h>
index a3ae0b4..9761541 100644 (file)
@@ -156,16 +156,6 @@ void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity)
 
 DEFINE_PER_CPU(unsigned long, thermal_pressure);
 
-void topology_set_thermal_pressure(const struct cpumask *cpus,
-                              unsigned long th_pressure)
-{
-       int cpu;
-
-       for_each_cpu(cpu, cpus)
-               WRITE_ONCE(per_cpu(thermal_pressure, cpu), th_pressure);
-}
-EXPORT_SYMBOL_GPL(topology_set_thermal_pressure);
-
 /**
  * topology_update_thermal_pressure() - Update thermal pressure for CPUs
  * @cpus        : The related CPUs for which capacity has been reduced
@@ -183,7 +173,7 @@ EXPORT_SYMBOL_GPL(topology_set_thermal_pressure);
 void topology_update_thermal_pressure(const struct cpumask *cpus,
                                      unsigned long capped_freq)
 {
-       unsigned long max_capacity, capacity;
+       unsigned long max_capacity, capacity, th_pressure;
        u32 max_freq;
        int cpu;
 
@@ -203,7 +193,10 @@ void topology_update_thermal_pressure(const struct cpumask *cpus,
        else
                capacity = mult_frac(max_capacity, capped_freq, max_freq);
 
-       arch_set_thermal_pressure(cpus, max_capacity - capacity);
+       th_pressure = max_capacity - capacity;
+
+       for_each_cpu(cpu, cpus)
+               WRITE_ONCE(per_cpu(thermal_pressure, cpu), th_pressure);
 }
 EXPORT_SYMBOL_GPL(topology_update_thermal_pressure);
 
index ace1e5d..cce6136 100644 (file)
@@ -56,9 +56,6 @@ static inline unsigned long topology_get_thermal_pressure(int cpu)
        return per_cpu(thermal_pressure, cpu);
 }
 
-void topology_set_thermal_pressure(const struct cpumask *cpus,
-                                  unsigned long th_pressure);
-
 void topology_update_thermal_pressure(const struct cpumask *cpus,
                                      unsigned long capped_freq);
 
index 6e89a8e..8054641 100644 (file)
@@ -266,13 +266,6 @@ unsigned long arch_scale_thermal_pressure(int cpu)
 }
 #endif
 
-#ifndef arch_set_thermal_pressure
-static __always_inline
-void arch_set_thermal_pressure(const struct cpumask *cpus,
-                              unsigned long th_pressure)
-{ }
-#endif
-
 #ifndef arch_update_thermal_pressure
 static __always_inline
 void arch_update_thermal_pressure(const struct cpumask *cpus,
index 036b750..086fd11 100644 (file)
@@ -550,7 +550,7 @@ config SCHED_THERMAL_PRESSURE
          i.e. put less load on throttled CPUs than on non/less throttled ones.
 
          This requires the architecture to implement
-         arch_set_thermal_pressure() and arch_scale_thermal_pressure().
+         arch_update_thermal_pressure() and arch_scale_thermal_pressure().
 
 config BSD_PROCESS_ACCT
        bool "BSD Process Accounting"