[media] exynos4-is: Add missing port parent of_node_put on error paths
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Tue, 26 Jan 2016 00:41:46 +0000 (22:41 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 19:22:52 +0000 (16:22 -0300)
In fimc_md_parse_port_node() remote port parent node is acquired with
of_graph_get_remote_port_parent() but it is not put on error path.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/exynos4-is/media-dev.c

index feb521f..48f62dc 100644 (file)
@@ -446,8 +446,10 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
        else
                pd->fimc_bus_type = pd->sensor_bus_type;
 
-       if (WARN_ON(index >= ARRAY_SIZE(fmd->sensor)))
+       if (WARN_ON(index >= ARRAY_SIZE(fmd->sensor))) {
+               of_node_put(rem);
                return -EINVAL;
+       }
 
        fmd->sensor[index].asd.match_type = V4L2_ASYNC_MATCH_OF;
        fmd->sensor[index].asd.match.of.node = rem;