HID: introduce proper dependency of HID_BATTERY on POWER_SUPPLY
authorJiri Kosina <jkosina@suse.cz>
Fri, 16 Dec 2011 22:35:55 +0000 (23:35 +0100)
committerJiri Kosina <jkosina@suse.cz>
Fri, 16 Dec 2011 22:35:55 +0000 (23:35 +0100)
ppc6xx_defconfig reveals this:

drivers/built-in.o: In function `hidinput_cleanup_battery': drivers/hid/hid-input.c:351: undefined reference to`power_supply_unregister'
drivers/built-in.o: In function `hidinput_setup_battery': drivers/hid/hid-input.c:338: undefined reference to `power_supply_register'
make[1]: *** [.tmp_vmlinux1] Error 1

The defconfig in question doens't mention either option and kbuild is
genertaing

CONFIG_HID_BATTERY_STRENGTH=y
CONFIG_POWER_SUPPLY=m

which is wrong. Put a proper dependency in place.

Reported-by: Tony Breeds <tony@bakeyournoodle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/Kconfig

index 3a97f1f..7745c3e 100644 (file)
@@ -33,7 +33,7 @@ config HID
 
 config HID_BATTERY_STRENGTH
        bool
-       depends on POWER_SUPPLY
+       depends on HID && POWER_SUPPLY && HID == POWER_SUPPLY
        default y
 
 config HIDRAW