ray_cs: Check ioremap return value
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Thu, 30 Dec 2021 02:29:26 +0000 (10:29 +0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 1 Feb 2022 12:24:35 +0000 (14:24 +0200)
As the possible failure of the ioremap(), the 'local->sram' and other
two could be NULL.
Therefore it should be better to check it in order to avoid the later
dev_dbg.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20211230022926.1846757-1-jiasheng@iscas.ac.cn
drivers/net/wireless/ray_cs.c

index 2987ad9..87e98ab 100644 (file)
@@ -382,6 +382,8 @@ static int ray_config(struct pcmcia_device *link)
                goto failed;
        local->sram = ioremap(link->resource[2]->start,
                        resource_size(link->resource[2]));
+       if (!local->sram)
+               goto failed;
 
 /*** Set up 16k window for shared memory (receive buffer) ***************/
        link->resource[3]->flags |=
@@ -396,6 +398,8 @@ static int ray_config(struct pcmcia_device *link)
                goto failed;
        local->rmem = ioremap(link->resource[3]->start,
                        resource_size(link->resource[3]));
+       if (!local->rmem)
+               goto failed;
 
 /*** Set up window for attribute memory ***********************************/
        link->resource[4]->flags |=
@@ -410,6 +414,8 @@ static int ray_config(struct pcmcia_device *link)
                goto failed;
        local->amem = ioremap(link->resource[4]->start,
                        resource_size(link->resource[4]));
+       if (!local->amem)
+               goto failed;
 
        dev_dbg(&link->dev, "ray_config sram=%p\n", local->sram);
        dev_dbg(&link->dev, "ray_config rmem=%p\n", local->rmem);