elementary: safely manipulate inlist and destroy part of it.

SVN revision: 80579

diff --git a/legacy/elementary/ChangeLog b/legacy/elementary/ChangeLog
index 8117123..5a8b282 100644 (file)
--- a/legacy/elementary/ChangeLog
+++ b/legacy/elementary/ChangeLog
@@ -801,3 +801,4 @@
 
        * Make sure private data is not NULL in elm_interface_scrollable.
        * Correctly handle failure case in _x11_notify_handler_image.
+       * Fix missuse of EINA_INLIST_FOREACH in elm_transit.c.

diff --git a/legacy/elementary/NEWS b/legacy/elementary/NEWS
index 08b3dd2..69b0f16 100644 (file)
--- a/legacy/elementary/NEWS
+++ b/legacy/elementary/NEWS
@@ -88,6 +88,7 @@ Fixes:
    * Fix focus problem in multibuttonentry. Entry can get focus only when multibuttonentry is focused.
    * Make sure private data is not NULL in elm_interface_scrollable.
    * Correctly handle failure case in _x11_notify_handler_image.
+   * Don't manipulate dead memory in Eina_Inlist in elm_transit.c.
 
 Removals:
 

diff --git a/legacy/elementary/src/lib/elm_transit.c b/legacy/elementary/src/lib/elm_transit.c
index 5b8025c..a7d99e5 100644 (file)
--- a/legacy/elementary/src/lib/elm_transit.c
+++ b/legacy/elementary/src/lib/elm_transit.c
@@ -222,8 +222,9 @@ static void
 _transit_remove_dead_effects(Elm_Transit *transit)
 {
    Elm_Transit_Effect_Module *effect_module;
+   Eina_Inlist *ll;
 
-   EINA_INLIST_FOREACH(transit->effect_list, effect_module)
+   EINA_INLIST_FOREACH_SAFE(transit->effect_list, ll, effect_module)
      {
         if (effect_module->deleted)
           {