net: asix: change the type of asix_set_sw/hw_mii to static
authorZhengchao Shao <shaozhengchao@huawei.com>
Mon, 4 Jul 2022 12:34:48 +0000 (20:34 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 Jul 2022 01:40:01 +0000 (18:40 -0700)
The functions of asix_set_sw/hw_mii are not called in other files, so
change them to static.

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20220704123448.128980-1-shaozhengchao@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/asix.h
drivers/net/usb/asix_common.c

index 45d3cc5..21c1ca2 100644 (file)
@@ -212,9 +212,6 @@ void asix_rx_fixup_common_free(struct asix_common_private *dp);
 struct sk_buff *asix_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
                              gfp_t flags);
 
-int asix_set_sw_mii(struct usbnet *dev, int in_pm);
-int asix_set_hw_mii(struct usbnet *dev, int in_pm);
-
 int asix_read_phy_addr(struct usbnet *dev, bool internal);
 
 int asix_sw_reset(struct usbnet *dev, u8 flags, int in_pm);
index b4a1b7a..9ea91c3 100644 (file)
@@ -68,6 +68,27 @@ void asix_write_cmd_async(struct usbnet *dev, u8 cmd, u16 value, u16 index,
                               value, index, data, size);
 }
 
+static int asix_set_sw_mii(struct usbnet *dev, int in_pm)
+{
+       int ret;
+
+       ret = asix_write_cmd(dev, AX_CMD_SET_SW_MII, 0x0000, 0, 0, NULL, in_pm);
+
+       if (ret < 0)
+               netdev_err(dev->net, "Failed to enable software MII access\n");
+       return ret;
+}
+
+static int asix_set_hw_mii(struct usbnet *dev, int in_pm)
+{
+       int ret;
+
+       ret = asix_write_cmd(dev, AX_CMD_SET_HW_MII, 0x0000, 0, 0, NULL, in_pm);
+       if (ret < 0)
+               netdev_err(dev->net, "Failed to enable hardware MII access\n");
+       return ret;
+}
+
 static int asix_check_host_enable(struct usbnet *dev, int in_pm)
 {
        int i, ret;
@@ -297,25 +318,6 @@ struct sk_buff *asix_tx_fixup(struct usbnet *dev, struct sk_buff *skb,
        return skb;
 }
 
-int asix_set_sw_mii(struct usbnet *dev, int in_pm)
-{
-       int ret;
-       ret = asix_write_cmd(dev, AX_CMD_SET_SW_MII, 0x0000, 0, 0, NULL, in_pm);
-
-       if (ret < 0)
-               netdev_err(dev->net, "Failed to enable software MII access\n");
-       return ret;
-}
-
-int asix_set_hw_mii(struct usbnet *dev, int in_pm)
-{
-       int ret;
-       ret = asix_write_cmd(dev, AX_CMD_SET_HW_MII, 0x0000, 0, 0, NULL, in_pm);
-       if (ret < 0)
-               netdev_err(dev->net, "Failed to enable hardware MII access\n");
-       return ret;
-}
-
 int asix_read_phy_addr(struct usbnet *dev, bool internal)
 {
        int ret, offset;