leds: lt3593: Put fwnode in any case during ->probe()
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Sat, 29 May 2021 11:19:33 +0000 (14:19 +0300)
committerPavel Machek <pavel@ucw.cz>
Tue, 3 Aug 2021 21:49:31 +0000 (23:49 +0200)
device_get_next_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: 8cd7d6daba93 ("leds: lt3593: Add device tree probing glue")
Cc: Daniel Mack <daniel@zonque.org>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-lt3593.c

index 3bb52d3..d0160fd 100644 (file)
@@ -97,10 +97,9 @@ static int lt3593_led_probe(struct platform_device *pdev)
        init_data.default_label = ":";
 
        ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data);
-       if (ret < 0) {
-               fwnode_handle_put(child);
+       fwnode_handle_put(child);
+       if (ret < 0)
                return ret;
-       }
 
        platform_set_drvdata(pdev, led_data);