projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2680690
)
memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings()
author
Liang He
<windhl@126.com>
Tue, 19 Jul 2022 08:56:40 +0000
(16:56 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:34:58 +0000
(12:34 +0200)
[ Upstream commit
48af14fb0eaa63d9aa68f59fb0b205ec55a95636
]
We should add the of_node_put() when breaking out of
for_each_child_of_node() as it will automatically increase
and decrease the refcount.
Fixes:
976897dd96db
("memory: Extend of_memory with LPDDR3 support")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link:
https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/memory/of_memory.c
patch
|
blob
|
history
diff --git
a/drivers/memory/of_memory.c
b/drivers/memory/of_memory.c
index
d0a80ae
..
1791614
100644
(file)
--- a/
drivers/memory/of_memory.c
+++ b/
drivers/memory/of_memory.c
@@
-283,6
+283,7
@@
const struct lpddr3_timings
if (of_device_is_compatible(np_tim, tim_compat)) {
if (of_lpddr3_do_get_timings(np_tim, &timings[i])) {
devm_kfree(dev, timings);
+ of_node_put(np_tim);
goto default_timings;
}
i++;