staging: comedi: Using macro DIV_ROUND_UP
authorsimran singhal <singhalsimran0@gmail.com>
Tue, 21 Feb 2017 18:28:26 +0000 (23:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:16:58 +0000 (09:16 +0100)
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)).
It clarifies the divisor calculations. This occurence was detected using
the coccinelle script:

@@
expression e1;
expression e2;
@@
(
- ((e1) + e2 - 1) / (e2)
+ DIV_ROUND_UP(e1,e2)
|
- ((e1) + (e2 - 1)) / (e2)
+ DIV_ROUND_UP(e1,e2)
)

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/addi_apci_3xxx.c
drivers/staging/comedi/drivers/cb_pcidas64.c

index b6af3eb..82c2211 100644 (file)
@@ -502,7 +502,7 @@ static int apci3xxx_ai_ns_to_timer(struct comedi_device *dev,
                        timer = *ns / base;
                        break;
                case CMDF_ROUND_UP:
-                       timer = (*ns + base - 1) / base;
+                       timer = DIV_ROUND_UP(*ns, base);
                        break;
                }
 
index efbf277..3b98193 100644 (file)
@@ -2007,7 +2007,7 @@ static unsigned int get_divisor(unsigned int ns, unsigned int flags)
 
        switch (flags & CMDF_ROUND_MASK) {
        case CMDF_ROUND_UP:
-               divisor = (ns + TIMER_BASE - 1) / TIMER_BASE;
+               divisor = DIV_ROUND_UP(ns, TIMER_BASE);
                break;
        case CMDF_ROUND_DOWN:
                divisor = ns / TIMER_BASE;