gst/gstdebugutils.c: Add some ideas, how to make the graph smaller.

Original commit message from CVS:
* gst/gstdebugutils.c:
Add some ideas, how to make the graph smaller.
* gst/gstutils.c:
Add a comment from a debug session.
* libs/gst/base/gstbasetransform.c:
Log more context.
* libs/gst/controller/gstinterpolationcontrolsource.c:
Indet.
* plugins/elements/gstcapsfilter.c:
Fix typo in docs.

diff --git a/ChangeLog b/ChangeLog
index ab7cd2e..cccf275 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2009-01-01  Stefan Kost  <ensonic@users.sf.net>
+
+       * gst/gstdebugutils.c:
+         Add some ideas, how to make the graph smaller.
+
+       * gst/gstutils.c:
+         Add a comment from a debug session.
+
+       * libs/gst/base/gstbasetransform.c:
+         Log more context.
+
+       * libs/gst/controller/gstinterpolationcontrolsource.c:
+         Indet.
+
+       * plugins/elements/gstcapsfilter.c:
+         Fix typo in docs.
+
 2008-12-27  Tim-Philipp Müller  <tim.muller at collabora co uk>
 
        * gst/gstbus.c: (gst_bus_dispose), (gst_bus_get_property),

diff --git a/gst/gstdebugutils.c b/gst/gstdebugutils.c
index 1d0463e..c115a10 100644 (file)
--- a/gst/gstdebugutils.c
+++ b/gst/gstdebugutils.c
@@ -22,6 +22,11 @@
  * edge [ constraint=false ];
  *   this creates strange graphs ("minlen=0" is better)
  * try puting src/sink ghostpads for each bin into invisible clusters
+ *
+ * for more compact nodes, try
+ * - changing node-shape from box into record
+ * - use labels like : element [ label="{element | <src> src | <sink> sink}"]
+ * - point to record-connectors : element1:src -> element2:sink
  */
 
 #include "gst_private.h"

diff --git a/gst/gstutils.c b/gst/gstutils.c
index 3442b09..53c4f6c 100644 (file)
--- a/gst/gstutils.c
+++ b/gst/gstutils.c
@@ -2533,6 +2533,7 @@ gst_buffer_stamp (GstBuffer * dest, const GstBuffer * src)
 static gboolean
 intersect_caps_func (GstPad * pad, GValue * ret, GstPad * orig)
 {
+  /* skip the pad, the request came from */
   if (pad != orig) {
     GstCaps *peercaps, *existing;
 

diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c
index 0c617d8..4d1f653 100644 (file)
--- a/libs/gst/base/gstbasetransform.c
+++ b/libs/gst/base/gstbasetransform.c
@@ -1033,7 +1033,8 @@ no_transform_possible:
   {
     GST_WARNING_OBJECT (trans,
         "transform could not transform %" GST_PTR_FORMAT
-        " in anything we support", caps);
+        " in anything we support (othercaps %" GST_PTR_FORMAT ")",
+        caps, othercaps);
     ret = FALSE;
     goto done;
   }

diff --git a/libs/gst/controller/gstinterpolationcontrolsource.c b/libs/gst/controller/gstinterpolationcontrolsource.c
index 9b2a9cd..ace4255 100644 (file)
--- a/libs/gst/controller/gstinterpolationcontrolsource.c
+++ b/libs/gst/controller/gstinterpolationcontrolsource.c
@@ -125,8 +125,9 @@ gst_interpolation_control_source_new (void)
  * Returns: %TRUE if the interpolation mode could be set, %FALSE otherwise
  */
 gboolean
-    gst_interpolation_control_source_set_interpolation_mode
-    (GstInterpolationControlSource * self, GstInterpolateMode mode) {
+gst_interpolation_control_source_set_interpolation_mode
+    (GstInterpolationControlSource * self, GstInterpolateMode mode)
+{
   gboolean ret = TRUE;
   GstControlSource *csource = GST_CONTROL_SOURCE (self);
 

diff --git a/plugins/elements/gstcapsfilter.c b/plugins/elements/gstcapsfilter.c
index bcef6ae..be30c33 100644 (file)
--- a/plugins/elements/gstcapsfilter.c
+++ b/plugins/elements/gstcapsfilter.c
@@ -22,7 +22,7 @@
 /**
  * SECTION:element-capsfilter
  *
- * The element does not modify data as such, but can enforce limmitations on the
+ * The element does not modify data as such, but can enforce limitations on the
  * data format.
  */