media: Revert "media: dw9768: activate runtime PM and turn off device"
authorSakari Ailus <sakari.ailus@linux.intel.com>
Wed, 13 Apr 2022 12:15:58 +0000 (13:15 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 24 Apr 2022 07:24:43 +0000 (08:24 +0100)
This reverts commit c09d776eaa060534a1663e3b89d842db3e1d9076.

Revert the commit as it breaks runtime PM support on OF based systems.
More fixes to the driver are needed.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/dw9768.c

index 65c6acf3ced9ad34c269c00a1fa27b3250d5454c..c086580efac78a850b8f5d8e853d8209f2fb4877 100644 (file)
@@ -469,11 +469,6 @@ static int dw9768_probe(struct i2c_client *client)
 
        dw9768->sd.entity.function = MEDIA_ENT_F_LENS;
 
-       /*
-        * Device is already turned on by i2c-core with ACPI domain PM.
-        * Attempt to turn off the device to satisfy the privacy LED concerns.
-        */
-       pm_runtime_set_active(dev);
        pm_runtime_enable(dev);
        if (!pm_runtime_enabled(dev)) {
                ret = dw9768_runtime_resume(dev);
@@ -488,7 +483,6 @@ static int dw9768_probe(struct i2c_client *client)
                dev_err(dev, "failed to register V4L2 subdev: %d", ret);
                goto err_power_off;
        }
-       pm_runtime_idle(dev);
 
        return 0;