kunit: no longer call module_info(test, "Y") for kunit modules
authorJoe Fradley <joefradley@google.com>
Tue, 23 Aug 2022 14:24:55 +0000 (07:24 -0700)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 30 Sep 2022 19:17:49 +0000 (13:17 -0600)
Because KUnit test execution is not a guarantee with the kunit.enable
parameter we want to be careful to only taint the kernel when actual
tests run. Calling module_info(test, "Y") for every KUnit module
automatically causes the kernel to be tainted upon module load. Therefore,
we're removing this call and relying on the KUnit framework to taint the
kernel or not.

Signed-off-by: Joe Fradley <joefradley@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
include/kunit/test.h

index a6d6892b7957639bb31ad0bb3dac5c83dde96c8e..20cc4770cb3f46766aab9b424329e1d68edab934 100644 (file)
@@ -253,7 +253,6 @@ static inline int kunit_run_all_tests(void)
 #endif /* IS_BUILTIN(CONFIG_KUNIT) */
 
 #define __kunit_test_suites(unique_array, ...)                                \
-       MODULE_INFO(test, "Y");                                                \
        static struct kunit_suite *unique_array[]                              \
        __aligned(sizeof(struct kunit_suite *))                                \
        __used __section(".kunit_test_suites") = { __VA_ARGS__ }