perf bpf augmented_raw_syscalls: Add an assert to make sure sizeof(augmented_arg...
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 21 Aug 2023 13:40:09 +0000 (10:40 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 21 Aug 2023 13:49:31 +0000 (10:49 -0300)
Similar to what was done in the previous cset for sizeof(saddr), we need
to make sure sizeof(augmented_arg->value) is a power of two to do bounds
checking using &=:

  augmented_len &= sizeof(augmented_arg->value) - 1;

Suggested-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/lkml/ZONrPo0NSqdbXiGx@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/bpf_skel/augmented_raw_syscalls.bpf.c

index 43549b6..90ce22f 100644 (file)
@@ -160,6 +160,7 @@ unsigned int augmented_arg__read_str(struct augmented_arg *augmented_arg, const
         */
        if (string_len > 0) {
                augmented_len -= sizeof(augmented_arg->value) - string_len;
+               _Static_assert(is_power_of_2(sizeof(augmented_arg->value)), "sizeof(augmented_arg->value) needs to be a power of two");
                augmented_len &= sizeof(augmented_arg->value) - 1;
                augmented_arg->size = string_len;
        } else {