[Contact] - removing warnings after adding the compilation option -Wall

[Verification] - the code compiles without any error and without warnings in Contact module

Change-Id: I52e2a0b123a0bf10cac7c11f06ec0c94319284d2
Signed-off-by: Andrzej Popowski <a.popowski@samsung.com>

diff --git a/src/contact/addressbook.cc b/src/contact/addressbook.cc
index 631612c23db5ff6af7407034b832e572295b2be2..d2535a41e2db3056b78ad2d411dbe31b2ac3f649 100755 (executable)
--- a/src/contact/addressbook.cc
+++ b/src/contact/addressbook.cc
@@ -225,7 +225,7 @@ PlatformResult AddressBookAddBatch(const JsonObject& args, JsonArray& out) {
       common::stol(FromJson<JsonString>(args, "addressBookId"));
   addressBookId = addressBookId == -1 ? 0 : addressBookId;
 
-  unsigned length = batch_args.size();
+  int length = static_cast<int>(batch_args.size());
   contacts_list_h contacts_list = NULL;
   int error_code = contacts_list_create(&contacts_list);
   if (CONTACTS_ERROR_NONE != error_code) {
@@ -280,7 +280,7 @@ PlatformResult AddressBookAddBatch(const JsonObject& args, JsonArray& out) {
     LoggerW("Added different number of contacts");
   }
 
-  for (unsigned int i = 0; i < count; i++) {
+  for (int i = 0; i < count; i++) {
     JsonObject out_object;
     contacts_record_h contact_record = nullptr;
     error_code =
@@ -390,7 +390,7 @@ PlatformResult AddressBookFind(const JsonObject& args, JsonArray& array) {
   if (status.IsError()) return status;
 
   contacts_list_first(list);
-  for (unsigned int i = 0; i < record_count; i++) {
+  for (int i = 0; i < record_count; i++) {
     contacts_record_h record;
     error_code = contacts_list_get_current_record_p(list, &record);
     status = ContactUtil::ErrorChecker(
@@ -664,7 +664,7 @@ PlatformResult AddressBookGetGroups(const JsonObject& args, JsonArray& out) {
 
   contacts_list_first(groups_list);
 
-  for (unsigned int i = 0; i < record_count; i++) {
+  for (int i = 0; i < record_count; i++) {
     contacts_record_h contacts_record;
     err = contacts_list_get_current_record_p(groups_list, &contacts_record);
     if (CONTACTS_ERROR_NONE != err || nullptr == contacts_record) {
@@ -756,7 +756,7 @@ void AddressBookListenerCallback(const char* view_uri, void* user_data) {
         result_obj.insert(std::make_pair(std::string("removed"),
             picojson::value(JsonArray{}))).first->second.get<JsonArray>();
 
-    for (unsigned int i = 0; i < count; i++) {
+    for (int i = 0; i < count; i++) {
       contacts_record_h contact_updated_record = nullptr;
 
       error_code = contacts_list_get_current_record_p(contacts_list,

diff --git a/src/contact/contact_manager.cc b/src/contact/contact_manager.cc
index a36baddd0dac759a8c04ca68a77790cf5fa60243..9cefd2c0507eef03e0559d93ebfc7595306db0e7 100755 (executable)
--- a/src/contact/contact_manager.cc
+++ b/src/contact/contact_manager.cc
@@ -74,7 +74,7 @@ PlatformResult ContactManagerGetAddressBooks(const JsonObject& args,
                           "Fail to get address book from list");
   }
 
-  for (unsigned int i = 0; i < record_count; i++) {
+  for (int i = 0; i < record_count; i++) {
     contacts_record_h contacts_record = nullptr;
     error_code = contacts_list_get_current_record_p(*contacts_list_ptr,
                                                     &contacts_record);
@@ -740,7 +740,7 @@ PlatformResult ContactManagerFind(const JsonObject& args, JsonArray& out) {
 
   contacts_list_first(person_list);
 
-  for (unsigned int i = 0; i < record_count; i++) {
+  for (int i = 0; i < record_count; i++) {
     contacts_record_h contacts_record;
     error_code =
         contacts_list_get_current_record_p(person_list, &contacts_record);

diff --git a/src/contact/contact_util.cc b/src/contact/contact_util.cc
index 40c180738c03e8bfc4d19654430de51eaf4ac8db..58ddc57156dc5847ac47844ef19b8f1c297ae20d 100755 (executable)
--- a/src/contact/contact_util.cc
+++ b/src/contact/contact_util.cc
@@ -257,7 +257,7 @@ PlatformResult ClearAllContactRecord(contacts_record_h contacts_record,
     return status;
   }
 
-  for (unsigned int i = 0; i < record_count; ++i) {
+  for (int i = 0; i < record_count; ++i) {
     unsigned int actual_index = record_count - 1 - i;
     contacts_record_h phone_record = nullptr;
     int err = contacts_record_get_child_record_at_p(
@@ -437,7 +437,7 @@ PlatformResult ImportContactNameFromContactsRecord(
   }
 
   JsonArray nicknames;
-  for (unsigned int i = 0; i < count; ++i) {
+  for (int i = 0; i < count; ++i) {
     contacts_record_h nickname = nullptr;
     err = contacts_record_get_child_record_at_p(
         contacts_record, _contacts_contact.nickname, i, &nickname);
@@ -2316,9 +2316,9 @@ PlatformResult ImportContactFromContactsRecord(
       return status;
     }
 
-    for (unsigned int i = 0; i < child_rec_count; ++i) {
+    for (int i = 0; i < child_rec_count; ++i) {
       JsonValue val{JsonObject{}};
-      data.import_func(contacts_record, i, &val.get<JsonObject>());
+      data.import_func(contacts_record, static_cast<unsigned int>(i), &val.get<JsonObject>());
       array.push_back(val);
     }
   }
@@ -2337,11 +2337,11 @@ PlatformResult ImportContactFromContactsRecord(
   }
 
   bool is_contact_anniv;
-  for (unsigned int i = 0; i < child_rec_count; ++i) {
+  for (int i = 0; i < child_rec_count; ++i) {
     JsonValue anniversary{JsonObject{}};
 
     PlatformResult status = ImportContactAnniversariesFromContactsRecord(
-        contacts_record, i, &anniversary.get<JsonObject>(), &is_contact_anniv);
+        contacts_record, static_cast<unsigned int>(i), &anniversary.get<JsonObject>(), &is_contact_anniv);
     if (status.IsError()) {
       LoggerE("Error: %s", status.message().c_str());
       return status;
@@ -2366,10 +2366,10 @@ PlatformResult ImportContactFromContactsRecord(
     return status;
   }
 
-  for (unsigned int i = 0; i < child_rec_count; ++i) {
+  for (int i = 0; i < child_rec_count; ++i) {
     JsonValue val{JsonObject{}};
 
-    status = ImportContactNotesFromContactsRecord(contacts_record, i, &val);
+    status = ImportContactNotesFromContactsRecord(contacts_record, static_cast<unsigned int>(i), &val);
     if (status.IsError()) {
       LoggerE("Error: %s", status.message().c_str());
       return status;